Repository navigation
Remove stale Streaming/OggVorbis exclude from Package.swift - #153
Open
KevinTCoughlin wants to merge 1 commit into
Open
KevinTCoughlin wants to merge 1 commit into
KevinTCoughlin wants to merge 1 commit into
Conversation
AudioStreaming/Streaming/OggVorbis was removed before the Ogg Vorbis support landed in dimitris-c#122; the decoder lives in AudioStreaming/OggVorbis and the stream processor in Streaming/AudioPlayer/Processors, both of which are compiled. The leftover exclude entry points at a path that does not exist, so SwiftPM emits an invalid-exclude warning on every resolve for every package that depends on AudioStreaming. No behavior change: nothing under the excluded path exists. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RQetM3A7aws53cE41m2cg4
KevinTCoughlin
marked this pull request as ready for review
November 7, 2026 01:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
AudioStreamingtarget excludesStreaming/OggVorbis, but that directory does not exist onmain, at 1.4.5 or at 1.4.4. It was on the Ogg Vorbis feature branch (added in 448ad71) and removed in fcba80c before #122 merged. The exclude entry stayed inPackage.swift.Because of it, building AudioStreaming as the root package (
swift buildin this repo, or CI) prints an invalid exclude warning (file not found). Packages that depend on AudioStreaming don't see it, because SwiftPM doesn't show those warnings for dependencies.The Ogg Vorbis code is unaffected.
AudioStreaming/OggVorbis/VorbisFileDecoder.swiftandStreaming/AudioPlayer/Processors/OggVorbisStreamProcessor.swiftare not under the excluded path, so they were compiled before this change and still are.Change: one line in
Package.swift. No other files change and behavior is the same.Tested on macOS (Xcode toolchain, Swift 6.3.3):
swift buildonmain: builds, with the invalid exclude warning.swift buildon this branch: builds, without the warning. All other warnings are the same as onmain.🤖 Generated with Claude Code